fix: add depends_on between cloud run service and IAM #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to reduce failure errors on destroy
NimJay
approved these changes
Jul 8, 2024
Contributor
NimJay
left a comment
NimJay
left a comment
There was a problem hiding this comment.
Thanks for doing this! Approved.
NimJay
reviewed
Jul 8, 2024
| | database\_username | Cloud SQL database name | `string` | `"server"` | no | | ||
| | enable\_apis | Whether or not to enable underlying apis in this solution. | `bool` | `true` | no | | ||
| | image\_version | Version of the container image to use | `string` | `"v1.9.0"` | no | | ||
| | image\_version | Version of the container image to use | `string` | `"v1.10.3"` | no | |
Contributor
There was a problem hiding this comment.
Rationale for change: lint was failing:
< | image\_version | Version of the container image to use | `string` | `"v1.9.0"` | no |
---
> | image\_version | Version of the container image to use | `string` | `"v1.10.3"` | no |
Contributor
There was a problem hiding this comment.
We should be good to merge now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported failures trying to delete deployments tell a tale of woe:
In theory, this is because the
terraform destoryis removing the google_cloud_run_v2_service before the google_cloud_run_service_iam_policy.Given that, this PR adds a
depends_onto the policy, which in theory should ensure a dependency graph where the policy is removed before the service.Also bumps avocano version to current latest (dependency updates)