Skip to content

Conversation

@glasnt
Copy link
Collaborator

@glasnt glasnt commented Apr 26, 2023

No description provided.

@glasnt glasnt marked this pull request as ready for review April 26, 2023 02:44
@glasnt glasnt requested review from a team and donmccasland as code owners April 26, 2023 02:44
@glasnt
Copy link
Collaborator Author

glasnt commented Apr 26, 2023

Re: change in 9af2904:

  on .terraform/modules/dynamic-python-webapp.gce-vpc/modules/subnets/main.tf line 29, in resource "google_compute_subnetwork" "subnetwork":
  29:   for_each                   = local.subnets
    ├────────────────
    │ local.subnets will be known only after apply

The "for_each" map includes keys derived from resource attributes that cannot
be determined until apply, and so Terraform cannot determine the full set of
keys that will identify the instances of this resource.

This is coming from the module itself. I added dynamic variables to the network, subnet, and instance because I thought that would be appropriate, but if subnets only need to be unique within the network, then making the subnet static should still allow for multiple deployments (in this scope).

@glasnt glasnt merged commit 518d795 into main Apr 28, 2023
@glasnt glasnt deleted the fix/gce-vpc-unique branch April 28, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants