Skip to content

Conversation

@glasnt
Copy link
Collaborator

@glasnt glasnt commented Apr 27, 2023

By default, random_suffix is true, meaning all elements are created with -nnnn.

We should also ensure we test the single deployment-per-project option.

simple_example: no suffix
suffix_example: random suffixes

@glasnt
Copy link
Collaborator Author

glasnt commented Apr 27, 2023

re: bc5e861

I borrowed from https://github.com/GoogleCloudPlatform/terraform-google-secure-cicd/blob/main/build/int.cloudbuild.yaml#L31 to run the multiple tests, but unsure why there's waitFors that appear to only be in series, so trying without those for now.

@glasnt
Copy link
Collaborator Author

glasnt commented Apr 28, 2023

This can't be merged until #58, as I don't believe the TF will succeed without it.

@grayside
Copy link
Contributor

waitFor in sequence is the same as no waitFor at all. However, looking closer at the terraform-google-secure-cicd config,

  • everything waits for init-all to complete
  • then there are two tracks that run in parallel:
    • Track 1: Sequentially: app_cicd, cloudbuild_private_pool, private_cluster_cicd
    • Track 2: standalone_single_project

Looking at the docs for waitFor:

If no values are provided for waitFor, the build step waits for all prior build steps in the build request to complete successfully before running.

On that basis, most of the waitFor configs could be removed, however if the "standalone_single_project" section were moved up in the file, it would break the parallelization of the build.

@glasnt
Copy link
Collaborator Author

glasnt commented May 16, 2023

This will be merged into #58, for testing completeness.

@glasnt glasnt closed this May 16, 2023
glasnt added a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants