performance: tune healthcheck for server behavior #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasnt
added a commit
to GoogleCloudPlatform/avocano
that referenced
this pull request
May 2, 2023
Collaborator
|
Testing this in https://github.com/GoogleCloudPlatform/avocano/tree/healthcheck-tune on avocano-preview |
grayside
changed the title
Collaborator
|
Based on discussions, closing this in favour of another method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the blueprint's exaggerated cold start penalty, originally documented in GoogleCloudPlatform/avocano#74.
Change
Impact
This is showing cold start page load taking just over 8 seconds, and that the initial request for site_config is taking 7.47 seconds. The screenshot also shows "7.33 seconds of "stalled" time, which may well be cold start/waiting for ready check.
Based on the updated settings in this PR, the first healtcheck at 5 seconds is successful. We should follow-up in the future with more optimization and a data-based approach to these numbers, but this is much better than the current slowness we're encountering of ~23 second first response