Skip to content
This repository was archived by the owner on Jul 16, 2024. It is now read-only.

Replace Arouter with RouterManagerImpl #29

Merged
merged 13 commits into from
Feb 11, 2022
Merged

Replace Arouter with RouterManagerImpl #29

merged 13 commits into from
Feb 11, 2022

Conversation

@Goooler
Copy link
Owner

@Goooler Goooler commented Feb 11, 2022 •
edited
Loading

Follow up #27.

Goooler
Goooler commented Feb 11, 2022
View reviewed changes
common/src/main/kotlin/io/goooler/demoapp/common/router/RouterManager.kt
Comment on lines 18 to 22
companion object : RouterManager {
const val PARAMS = "params"
const val RE_LOGIN = "reLogin"
const val USE_CHROME = "useChrome"

@Inject
lateinit var impl: RouterManager
Copy link
Owner Author

@Goooler Goooler Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Dagger does not support injection into Kotlin objects

Dagger does not support injection into static fields

@Goooler
Copy link
Owner Author

Goooler commented Feb 11, 2022 

2022-02-11 14:51:05.545 11872-11872/? E/AndroidRuntime: FATAL EXCEPTION: main
    Process: io.goooler.demoapp, PID: 11872
    java.lang.RuntimeException: Unable to start activity ComponentInfo{io.goooler.demoapp/io.goooler.demoapp.login.ui.SplashActivity}: kotlin.UninitializedPropertyAccessException: lateinit property impl has not been initialized
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3635)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3792)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2210)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
     Caused by: kotlin.UninitializedPropertyAccessException: lateinit property impl has not been initialized
        at io.goooler.demoapp.common.router.RouterManager.getImpl(RouterManager.kt:8)
        at io.goooler.demoapp.common.router.RouterManager.goMain(RouterManager.kt:19)
        at io.goooler.demoapp.login.ui.SplashActivity.onCreate(SplashActivity.kt:12)
        at android.app.Activity.performCreate(Activity.java:8051)
        at android.app.Activity.performCreate(Activity.java:8031)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1329)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3608)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3792) 
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103) 
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2210) 
        at android.os.Handler.dispatchMessage(Handler.java:106) 
        at android.os.Looper.loopOnce(Looper.java:201) 
        at android.os.Looper.loop(Looper.java:288) 
        at android.app.ActivityThread.main(ActivityThread.java:7839) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003) 

@Goooler Goooler added this to the 1.5.0 milestone Feb 11, 2022
@Goooler Goooler added the enhancement New feature or request label Feb 11, 2022
@Goooler Goooler merged commit 2d93567 into kotlin Feb 11, 2022
@Goooler Goooler deleted the router branch February 11, 2022 08:25
@Goooler Goooler mentioned this pull request Feb 17, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Goooler