Skip to content

Conversation

@GordonSmith
Copy link
Owner

No description provided.

@GordonSmith GordonSmith requested a review from Copilot August 30, 2025 20:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the vcpkg dependency manager and the wasm-micro-runtime package from version 2.2.0 to 2.4.1, and includes fixes to resolve Windows CI build issues.

  • Updates vcpkg baseline and wasm-micro-runtime version with corresponding SHA512 hash
  • Adds header guards and inline specifiers to prevent multiple definition errors
  • Fixes array declaration and type consistency issues for cross-platform compatibility

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vcpkg_overlays/wasm-micro-runtime/vcpkg.json Updates package version from 2.2.0 to 2.4.1
vcpkg_overlays/wasm-micro-runtime/portfile.cmake Updates SHA512 hash for new version
vcpkg-configuration.json Updates vcpkg baseline commit
vcpkg Updates vcpkg submodule commit
include/wamr.hpp Adds header guards, inline specifiers, and fixes array size issue
include/cmcpp/traits.hpp Replaces std math functions with constexpr alternatives and fixes template recursion
include/cmcpp/lower.hpp Changes uint to uint32_t for type consistency
include/cmcpp/lift.hpp Changes uint to uint32_t for type consistency
include/cmcpp/context.hpp Updates function type template syntax
CMakeLists.txt Disables samples by default on Windows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

include/wamr.hpp Outdated

constexpr size_t output_size = std::is_same<result_t, void>::value ? 0 : 1;
wasm_val_t outputs[output_size];
wasm_val_t outputs[output_size == 0 ? 1 : output_size];
Copy link

Copilot AI Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero-length arrays are not standard C++. However, the ternary operator fix output_size == 0 ? 1 : output_size ensures the array always has at least one element, which resolves the compilation issue but may waste memory when no outputs are expected. Consider using a conditional compilation approach or std::array with template specialization for better type safety.

Copilot uses AI. Check for mistakes.
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit 103ba3a into trunk Aug 31, 2025
3 of 5 checks passed
@GordonSmith GordonSmith deleted the BUMP_VCPKG branch August 31, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants