SRAMP-421 S-ramp shell UploadArtifactCommand Add name and description#412
SRAMP-421 S-ramp shell UploadArtifactCommand Add name and description#412dvirgiln wants to merge 1 commit intoArtificerRepo:masterfrom
Conversation
There was a problem hiding this comment.
Some problems here:
- Please do not re-order the arguments as that would potentially affect anyone with an existing s-ramp CLI command file. So please revert artifactType to be argument 1 and make name argument 2.
- Please update the Usage documentation (help text) for the command to indicate the new optional argument.
There was a problem hiding this comment.
I think is not possible to put the argument one (artifactType) as optional and then mandatory the argument two (the name).
How I can know that when the user introduce "upload fileToUpload parameter" which parameter is the value "parameter"? Is it the artifactType or it is the name... with aesh 0.53, using named args, this would have been solved
There was a problem hiding this comment.
Agreed - the name should be optional. It should use the filename if no name is provided. So in this way there is only one required argument (file path) and two optional (type, name).
|
I am closing this PR for now. We are deferring this change for a future when we change the CLI to use unordered arguments like this: This will happen when we are able to use the latest AESH version. |
https://issues.jboss.org/browse/SRAMP-421