This repository was archived by the owner on Sep 24, 2019. It is now read-only.
Node Interface #20
Merged
Node Interface #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuorig
commented
Feb 11, 2017
app/models/graph/schema.rb
Outdated
Collaborator
Author
There was a problem hiding this comment.
Can also be better if we have model on metadata, think it would be cool
cjoudrey
reviewed
Feb 11, 2017
|
|
||
| object_from_id ->(id, query_ctx) do | ||
| gid = GlobalID.parse(id) | ||
| Object.const_get(gid.model_name).find(gid.model_id) |
Contributor
There was a problem hiding this comment.
Maybe I'm a bit paranoid, but think we should do this?
type_name = uri.model_name.to_sym
if uri.app != GlobalID.app || !Graph::Types.constants.include?(type_name)
raise GraphQL::ExecutionError, "Invalid gid: #{gid}"
end
Object.const_get(gid.model_name).find(gid.model_id)
xuorig
commented
Feb 11, 2017
|
|
||
| object_from_id ->(id, query_ctx) do | ||
| gid = GlobalID.parse(id) | ||
| possible_types = query_ctx.warden.possible_types(GraphQL::Relay::Node.interface) |
Collaborator
Author
There was a problem hiding this comment.
cc @cjoudrey good point, I think this is more even more accurate ^
Collaborator
Author
|
merging to keep going forward, let me know if you find anything else, will fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @cjoudrey