Skip to content

Conversation

indierusty
Copy link
Collaborator

@indierusty indierusty commented Jan 3, 2025

Accidentally merged (but not included in master), replaced by #2183.

@indierusty indierusty requested a review from Keavon January 4, 2025 12:51
@Keavon Keavon changed the title add function to calculate if a subpath is inside polygon Bezier-rs: Add function to calculate if a subpath is inside polygon Jan 6, 2025
@Keavon Keavon marked this pull request as draft January 6, 2025 10:29
@indierusty indierusty marked this pull request as ready for review January 7, 2025 04:47
@Keavon Keavon requested a review from Copilot January 10, 2025 05:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

website/other/bezier-rs-demos/wasm/src/subpath.rs:446

  • The function inside_subpath is missing test coverage. Add tests to ensure its correctness.
pub fn inside_subpath(&self, js_points: JsValue, error: f64, minimum_separation: f64) -> String {

@Keavon Keavon merged commit e7ca0a7 into GraphiteEditor:master Jan 10, 2025
@Keavon
Copy link
Member

Keavon commented Jan 10, 2025

Because this branch was named master and I had to do a bunch of workarounds to even be able to pull this down locally for my code review, I ended up accidentally pushing my commit to the origin remote instead of your fork's remote, which merged all these commits into the mainline master and I had to pop those off to revert it. But unfortunately GitHub thinks this PR was merged, and that can't be undone to reopen it, so you'll need to open a new one. Before you do that, please rename your branch something other than master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants