Skip to content

Conversation

wade-cheng
Copy link

Does not close any issue, but I was looking into #2532, a Paper Cut issue that requests parity between the canvas and node graph by adding the lasso select, which has no keybind conflicts. This is my very first PR here, and it was a bit out of my depth.

I wanted to start a bit smaller, and noticed that the node graph could include alt-to-subtract selections without keybind conflicts, because none of the alt keybinds correspond to left clicks on the background!

2025-10-15.16-54-19.mp4

All the other Alt keybinds like Move Duplicate and Preview Node Output still work as expected.

@timon-schelling
Copy link
Member

!build

@github-actions
Copy link

📦 Build Complete for 2573298
https://8ae24231.graphite.pages.dev

Copy link
Member

@timon-schelling timon-schelling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like described, implementation LGTM.
Not sure if we want this shortcut though, for me this feels like a good idea.
Also did not look for conflicts with other key binds.

HintGroup(vec![
HintInfo::mouse(MouseMotion::LmbDrag, "Select Area"),
HintInfo::keys([Key::Shift], "Extend").prepend_plus(),
HintInfo::keys([Key::Alt], "Subtract").prepend_plus(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if subtracting is the right terminology.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be, that's how the graphite select tool and the wider ecosystem terms it: https://www.google.com/search?q=subtract%20selection (though I believe Pinta uses the proper set vocabulary which is pretty neat)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants