Skip to content

Fix copying nodes sometimes failing when no OutputConnector exists #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2025
Merged

Fix copying nodes sometimes failing when no OutputConnector exists #3365

merged 2 commits into from
Nov 10, 2025

Conversation

@0HyperCube
Copy link
Contributor

@0HyperCube 0HyperCube commented Nov 10, 2025

To reproduce:

  • Create a blank document with an infinite canvas
  • Open node graph
  • Create rectangle node via right click
  • Select rectangle node
  • Ctrl + C
  • Nothing is copied and the error is logged: 
    editor/src/messages/portfolio/document/utility_types/network_interface.rs:373
Could not get outward wires in copy_nodes

Keavon
Keavon approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks for tracking this down and solving it.

@Keavon Keavon changed the title Fix copy nodes sometimes failing when no OutputConnector exists Fix copying nodes sometimes failing when no OutputConnector exists Nov 10, 2025
@Keavon Keavon enabled auto-merge (squash) November 10, 2025 20:08
@Keavon Keavon merged commit 7f10a42 into GraphiteEditor:master Nov 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keavon Keavon Keavon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0HyperCube @Keavon