Fix Vello renderer crash when element has no stroke #3373
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash in the Vello renderer that occurred when rendering elements without a defined stroke. The fix replaces two unsafe .unwrap() calls with safe .map_or() calls that default to a stroke width of 0.0.
- Replaced
.unwrap()with.as_ref().map_or(0., Stroke::effective_width)to safely handle missing strokes - Applied the fix in two locations where stroke width is used for bounding box inflation
- Uses 0.0 as the default stroke width, which is appropriate since it results in no bounding box inflation when no stroke is present
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Keavon
approved these changes
Nov 13, 2025
Member
|
Thanks. Please comment in the issue this PR fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3361
The Vello renderer was calling
.unwrap()onstroke(), which returns an Option. When an element had no stroke defined, this caused a panic.Used
.as_ref().map_or(0., Stroke::effective_width)instead. This returns a stroke width of 0.0 when no stroke is present.