Respect artboard clipping when computing canvas scrollbars #3387
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
!build |
|
Contributor
Author
|
I think the build works fine @TrueDoctor |
Keavon
reviewed
Nov 17, 2025
editor/src/messages/portfolio/document/navigation/navigation_message_handler.rs
Outdated
Show resolved
Hide resolved
Keavon
reviewed
Nov 17, 2025
editor/src/messages/portfolio/document/navigation/navigation_message_handler.rs
Outdated
Show resolved
Hide resolved
ashishmohapatra240
force-pushed
the
fix/artboard-clipping-scrollbars
branch
from
a0a38df to
ae503fb
Compare
Keavon
force-pushed
the
fix/artboard-clipping-scrollbars
branch
from
ae503fb to
a73582c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2846
Added
NetworkInterface::document_bounds_viewport_space(include_artboards)that converts clipping‑aware document bounds into viewport space, and updatedRenderScrollbarsto use the new helper so scroll extents respect artboard clipping.Please check if this is the intended behaviour.
Graphite4.mp4