Fix 'Mask' node missing Properties widget; fix crash with 'Brightness/Contrast Classic' node #3404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I added one commit to properly format type names and another to ensure protonode widgets are based on the current type, not the definition. Other than that it looks good. |
Member
Author
|
Thanks @adamgerhant. Looks like it's failing to build though, can you fix that please? What s your second commit (78d17b1) about? |
adamgerhant
force-pushed
the
fix-properties-panel-bugs
branch
from
78d17b1 to
330903f
Compare
Collaborator
|
Second commit moved into #3407 |
adamgerhant
approved these changes
Nov 21, 2025
…/Contrast Classic' node Also clean up dead code and improve tooltip for the "-" Properties panel widget fallback.
Keavon
force-pushed
the
fix-properties-panel-bugs
branch
from
330903f to
aef8b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleans up dead code and improves the tooltip for the "-" Properties panel widget fallback.