fix(client): delete "title" from arguments in BasicSearch.create_job #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1997171787
💛 - Coveralls |
AChenQ
requested changes
Mar 17, 2022
| "commit": self._status.commit_id, | ||
| "conjunction": conjunction, | ||
| "filters": filters, | ||
| "unit": unit, |
There was a problem hiding this comment.
commit message:
delete the "title" argument in BasicSearch.create_job
maybe better?
willandfree
force-pushed
the
T21746_basic_search_create_job
branch
from
74783e9 to
0b4862d
Compare
willandfree
changed the title
AChenQ
approved these changes
Mar 17, 2022
willandfree
force-pushed
the
T21746_basic_search_create_job
branch
from
0b4862d to
b011108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.