feat(cli): support listing drafts in "gas draft -l" command #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 848855568
💛 - Coveralls |
rexzheng324-c
force-pushed
the
T15229_gas_draft_list
branch
3 times, most recently
from
744e29c to
8423ee8
Compare
linjiX
requested changes
May 17, 2021
|
|
||
| if is_list: | ||
| pass | ||
| _list_drafts(dataset_client, info) |
There was a problem hiding this comment.
The draft_number and revision should also be checked
rexzheng324-c
force-pushed
the
T15229_gas_draft_list
branch
from
8423ee8 to
6dca0ec
Compare
linjiX
requested changes
May 17, 2021
tensorbay/cli/draft.py
Outdated
| sys.exit(1) | ||
|
|
||
| for draft in dataset_client.list_drafts(): | ||
| if info.draft_number: |
rexzheng324-c
force-pushed
the
T15229_gas_draft_list
branch
3 times, most recently
from
2494ea8 to
1ef6ed1
Compare
linjiX
approved these changes
May 17, 2021
rexzheng324-c
force-pushed
the
T15229_gas_draft_list
branch
from
1ef6ed1 to
bc39640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.