style(client): fix mypy errors in FusionDatasetClient._skip_upload_frame #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 860331268
💛 - Coveralls |
linjiX
requested changes
May 20, 2021
| @staticmethod | ||
| def _skip_upload_frame( | ||
| segment_filter: Iterator[Tuple[Frame, Optional[int], bool]], | ||
| segment_filter: Iterator[Tuple[Frame, Optional[float], bool]], |
There was a problem hiding this comment.
better to paste the mypy error detail in commit message body
There was a problem hiding this comment.
- Put the error detail into code block in commit message body
error->errorsin commit message
Lee-000
approved these changes
May 20, 2021
QianBao8902
force-pushed
the
T15529_timestamp
branch
from
4f781bc to
4e1c8fb
Compare
linjiX
requested changes
May 20, 2021
| @staticmethod | ||
| def _skip_upload_frame( | ||
| segment_filter: Iterator[Tuple[Frame, Optional[int], bool]], | ||
| segment_filter: Iterator[Tuple[Frame, Optional[float], bool]], |
There was a problem hiding this comment.
- Put the error detail into code block in commit message body
error->errorsin commit message
QianBao8902
force-pushed
the
T15529_timestamp
branch
5 times, most recently
from
ef90847 to
f5c97f0
Compare
QianBao8902
changed the title
linjiX
approved these changes
May 20, 2021
QianBao8902
force-pushed
the
T15529_timestamp
branch
from
f5c97f0 to
384ae56
Compare
Errors in mypy: ``` tensorbay/client/dataset.py|708 col 29 error Incompatible types in assignment(expression has type "float", variable has type "Optional[int]")[assignment] tensorbay/client/dataset.py|709 col 41 error Argument 1 to "get" of "Mapping" has incompatible type "Optional[int]"; expected "float"[arg-type] ``` PR Closed: Graviti-AI#590
QianBao8902
force-pushed
the
T15529_timestamp
branch
from
384ae56 to
a2a99be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors in mypy: