test(client): add unit test for GAS class #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AChenQ
force-pushed
the
T15773_client_unit_test
branch
from
babbddc to
0a3ffc6
Compare
AChenQ
force-pushed
the
T15773_client_unit_test
branch
2 times, most recently
from
bc7c0ce to
decd0b5
Compare
Pull Request Test Coverage Report for Build 918259120
💛 - Coveralls |
AChenQ
force-pushed
the
T15773_client_unit_test
branch
2 times, most recently
from
ab2a662 to
c95052b
Compare
AChenQ
force-pushed
the
T15773_client_unit_test
branch
from
c95052b to
636edfa
Compare
AChenQ
force-pushed
the
T15773_client_unit_test
branch
from
636edfa to
63a3f46
Compare
rexzheng324-c
approved these changes
Jun 3, 2021
AChenQ
force-pushed
the
T15773_client_unit_test
branch
2 times, most recently
from
fcfd0b6 to
c53a8dd
Compare
linjiX
requested changes
Jun 3, 2021
tensorbay/client/tests/test_gas.py
Outdated
| assert dataset_client._status.branch_name == "main" | ||
| get_dataset.assert_called_once_with("test") | ||
|
|
||
| def test_get_dataset_(self, mocker): |
There was a problem hiding this comment.
check famous third party project and try to find out how to handle the test case of private function.
linjiX
requested changes
Jun 3, 2021
linjiX
requested changes
Jun 3, 2021
AChenQ
force-pushed
the
T15773_client_unit_test
branch
5 times, most recently
from
f7a67ef to
a8bdb93
Compare
linjiX
requested changes
Jun 7, 2021
tensorbay/client/tests/test_gas.py
Outdated
| ) | ||
| configs = self.gas_client.list_auth_storage_configs() | ||
|
|
||
| assert len(configs) == 1 |
There was a problem hiding this comment.
do we need to check the value in configs?
| "owner": "", | ||
| "id": "123456", | ||
| } | ||
| get_dataset = mocker.patch( |
There was a problem hiding this comment.
do we need a specific naming convention for mocker function?
There was a problem hiding this comment.
A specific name may seems clearer
AChenQ
force-pushed
the
T15773_client_unit_test
branch
from
a8bdb93 to
1401cba
Compare
linjiX
requested changes
Jun 8, 2021
AChenQ
force-pushed
the
T15773_client_unit_test
branch
from
1401cba to
8d8409f
Compare
linjiX
approved these changes
Jun 8, 2021
AChenQ
force-pushed
the
T15773_client_unit_test
branch
from
8d8409f to
2bab876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.