Skip to content

Conversation

@yuyouyu32
Copy link
Collaborator

No description provided.

@yuyouyu32 yuyouyu32 changed the title test(client): add test function for copy segment test: add test cases for copy segment Jun 29, 2021
@coveralls
Copy link

coveralls commented Jun 29, 2021

Pull Request Test Coverage Report for Build 982252197

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.759%

Totals Coverage Status
Change from base Build 982198063: 0.0%
Covered Lines: 4982
Relevant Lines: 5948

💛 - Coveralls

)
assert segment_client.name == "Segment2"

with pytest.raises(InvalidParamsError):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this case is tested before, there is no need to test it again here.

dataset_client.commit("commit_2")

dataset_client_1 = gas_client.get_dataset(dataset_name)
dataset_client_1 = gas_client.get_dataset(dataset_name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated Code.

)
assert segment_client.name == "Segment2"

with pytest.raises(InvalidParamsError):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@yuyouyu32 yuyouyu32 force-pushed the T16377_copy_test branch 5 times, most recently from 01c6886 to 6a0a55c Compare June 29, 2021 09:40
@yuyouyu32 yuyouyu32 changed the title test: add test cases for copy segment test: add test cases for copy segment from another dataset or commit Jun 29, 2021
@yuyouyu32 yuyouyu32 force-pushed the T16377_copy_test branch 3 times, most recently from 662c9d5 to a3636c5 Compare June 29, 2021 10:04
@yuyouyu32 yuyouyu32 merged commit cc5fedc into Graviti-AI:main Jun 29, 2021
@yuyouyu32 yuyouyu32 deleted the T16377_copy_test branch June 29, 2021 10:13
linjiX pushed a commit that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants