- 
                Notifications
    
You must be signed in to change notification settings  - Fork 35
 
test: add test cases for copy segment from another dataset or commit #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6b7707    to
    ae9fe28      
    Compare
  
    
          Pull Request Test Coverage Report for Build 982252197
 
 💛 - Coveralls | 
    
ae9fe28    to
    e66d110      
    Compare
  
            
          
                tests/test_move_and_copy.py
              
                Outdated
          
        
      | ) | ||
| assert segment_client.name == "Segment2" | ||
| 
               | 
          ||
| with pytest.raises(InvalidParamsError): | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this case is tested before, there is no need to test it again here.
| dataset_client.commit("commit_2") | ||
| 
               | 
          ||
| dataset_client_1 = gas_client.get_dataset(dataset_name) | ||
| dataset_client_1 = gas_client.get_dataset(dataset_name) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated Code.
        
          
                tests/test_move_and_copy.py
              
                Outdated
          
        
      | ) | ||
| assert segment_client.name == "Segment2" | ||
| 
               | 
          ||
| with pytest.raises(InvalidParamsError): | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
01c6886    to
    6a0a55c      
    Compare
  
    662c9d5    to
    a3636c5      
    Compare
  
    a3636c5    to
    7881cf9      
    Compare
  
    
No description provided.