refactor: change the arguments of "set_rotation" in sensor and transform #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1090271622
💛 - Coveralls |
Lee-000
force-pushed
the
T17207_change_set_rotation_args
branch
2 times, most recently
from
3f1c30b to
108af63
Compare
linjiX
approved these changes
Aug 2, 2021
tensorbay/sensor/sensor.py
Outdated
| y: Optional[float] = None, | ||
| z: Optional[float] = None, | ||
| *, | ||
| rotation: Optional[quaternion] = None, |
There was a problem hiding this comment.
will it be better to use quaternion as the argument name?
AChenQ
approved these changes
Aug 2, 2021
Lee-000
force-pushed
the
T17207_change_set_rotation_args
branch
from
108af63 to
5f1a5f4
Compare
linjiX
pushed a commit
that referenced
this pull request
Aug 3, 2021
linjiX
pushed a commit
that referenced
this pull request
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.