Use sqlite_string_mode not sqlite_unicode (#21)#22
Merged
Grinnz merged 1 commit intoGrinnz:masterfrom Aug 1, 2021
Merged
Conversation
Contributor
Author
|
I was assuming there would be CI to check my perl. :D |
Owner
|
Travis is pretty much unusable now and I havent set up github actions on my repos yet. |
Grinnz
reviewed
Jul 30, 2021
Contributor
Author
|
Thanks, wasn't sure how those worked. I'll tweak those shortly. |
AdamWill
force-pushed
the
dbd-unicode-change
branch
from
a00d545 to
a88f3a4
Compare
DBD::SQLite wants to move away from the use of `sqlite_unicode` in favor of setting `sqlite_string_mode`. This requires version 1.68 or higher of DBD::SQLite. Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill
force-pushed
the
dbd-unicode-change
branch
from
a88f3a4 to
383298a
Compare
Owner
|
Thanks! |
Grinnz
added a commit
that referenced
this pull request
Aug 2, 2021
- Increase DBD::SQLite dependency to 1.68 to support and use sqlite_string_mode over sqlite_unicode (#22, Adam Williamson) - The default options now set sqlite_string_mode to DBD_SQLITE_STRING_MODE_UNICODE_FALLBACK, unless sqlite_unicode is specified explicitly in from_string or from_filename. This is equivalent to the previous behavior but ensures that DBD::SQLite will not return malformed strings. - Support wal_mode option to enable WAL journaling mode, which is still currently the default, but may not be set by default in a future release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBD::SQLite wants to move away from the use of
sqlite_unicodein favor of setting
sqlite_string_mode. This requiresversion 1.68 or higher of DBD::SQLite.
Signed-off-by: Adam Williamson awilliam@redhat.com