Restore: Upgrade @gusto/embedded-api to 0.10.0 #758
Merged
+116
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Contributor
Author
|
@SocketSecurity ignore npm/typescript@5.9.3 |
This reverts commit a9c1e50.
jeffredodd
force-pushed
the
restore/upgrade-embedded-api-0.10.0
branch
from
eecb451 to
3637b0c
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores the upgrade of @gusto/embedded-api from version 0.8.1 to 0.10.0 by reverting a previous revert commit. The upgrade adapts to API changes in the newer version by destructuring and excluding the reimbursements field from employee compensation transformations.
Key Changes:
- Upgrades @gusto/embedded-api dependency from 0.8.1 to 0.10.0
- Updates two component files to handle the new
reimbursementsfield inPayrollEmployeeCompensationsType
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates @gusto/embedded-api dependency version from ^0.8.1 to ^0.10.0 |
| src/components/Payroll/PayrollConfiguration/PayrollConfiguration.tsx | Extracts reimbursements field in transformEmployeeCompensation function to exclude it from the spread operator |
| src/components/Payroll/PayrollEditEmployee/PayrollEditEmployee.tsx | Extracts reimbursements field in transformEmployeeCompensation function to exclude it from the spread operator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the embedded-api upgrade that was temporarily reverted in PR #757.
What This Does
Reverts the revert commit (a9c1e50), which restores the original changes from commit 714b753:
When to Merge
DO NOT MERGE until after the release is complete.
This PR is in draft status and should only be moved to ready/merged after:
Original Context
save/upgrade-embedded-api-0.10.0(preserved for reference)Files Affected