Skip to content

Conversation

@azrosen92
Copy link
Collaborator

@azrosen92 azrosen92 commented Feb 12, 2025

Use the remote overlay file set up in https://github.com/Gusto/Gusto-Partner-API/pull/839 along with the local one. The local file is merged with the remote file in order to overlay the zip -> zip_code rename that is unique to python.

Confirmed successful code generation: https://github.com/Gusto/gusto-python-client/actions/runs/13294026698/job/37121473880

@azrosen92 azrosen92 force-pushed the ar/remote-overlay-file branch from e765746 to bcef3d3 Compare February 12, 2025 20:25
@azrosen92 azrosen92 marked this pull request as ready for review February 12, 2025 20:31
@azrosen92 azrosen92 requested a review from a team February 12, 2025 20:39
- location: https://raw.githubusercontent.com/Gusto/Gusto-Partner-API/refs/heads/main/.speakeasy/speakeasy-modifications-overlay.yaml
authHeader: Authorization
authSecret: $openapi_doc_auth_token
- location: gusto_embedded/.speakeasy/speakeasy-modifications-overlay.yaml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove this file?

Copy link
Collaborator Author

@azrosen92 azrosen92 Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not here, we need it because it contains the name overrides for zip, which only apply to python

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it!

@azrosen92 azrosen92 merged commit 02b0880 into main Feb 14, 2025
1 check passed
@azrosen92 azrosen92 deleted the ar/remote-overlay-file branch February 14, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants