Expose same functionality in MaterialTextBox as TextBox #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the MaterialTextBox doesn't extend the GWT standard TextBox, but we still want to provide the same possibilities as the TextBox has, we need to implement all the interfaces that TextBox does and redirect the methods to the internal TextBox. Also, the inner components should be protected instead of package private, to expose them to extensions.
Contributor
Author
|
I came across this flaw when I tested out stephenh/tessell, a data binding library for GWT. I couldn't do any bindings what so ever with MaterialTextBox. |
kevzlou7979
added a commit
that referenced
this pull request
Jul 3, 2015
Expose same functionality in MaterialTextBox as TextBox
|
I have compilation error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the MaterialTextBox doesn't extend the GWT standard TextBox, but
we still want to provide the same possibilities as the TextBox has, we
need to implement all the interfaces that TextBox does and redirect the
methods to the internal TextBox.
Also, the inner components should be protected instead of package
private, to expose them to extensions.