Skip to content

Conversation

@AndreasAlbert
Copy link
Collaborator

No description provided.

@clelange
Copy link
Collaborator

Currently, we get Python 3.9.5 with homebrew/ROOT as default. Any particular reason why you're explicitly choosing Python 3.8 here?

@AndreasAlbert
Copy link
Collaborator Author

No, tbh, I was just playing around trying to get it to work. (I did not know the python version from homebrew/ROOT)

@AndreasAlbert
Copy link
Collaborator Author

I'm confused actually that this now says that tests pass...When I last touched the code, I thought the tests were still failing? oO

@clelange
Copy link
Collaborator

We can stick to Python 3.8 or we go with the Homebrew default that we get with root (i.e not even install python explicitly with brew, but only brew install root). The latter might be easier. I'm actually a bit surprised this didn't cause issues.

@matthewfeickert
Copy link
Member

@clelange I think this can get closed given the addition of

include:
- os: macos-latest
root-version: "6.26"
python-version: "3.10"

in PR #220.

@clelange
Copy link
Collaborator

Superseded by #220

@clelange clelange closed this Feb 23, 2023
@clelange clelange deleted the 2021-06-17_ci branch February 23, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants