Enhance the readability of doc-sites examples #6040
Merged
+209
−228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly in examples Updated multiple DatePicker components across various example files to simplify the onChange handler by directly using setSelectedDate instead of wrapping it in an arrow function. This change enhances code readability and consistency and avoid the unnecessary wrapper
…dability Extracted the custom header rendering logic into a separate function, renderHeader, to enhance code clarity and maintainability in the RenderCustomHeaderTwoMonths example. This change simplifies the DatePicker component's renderCustomHeader prop.
…andling Updated the handleChangeRaw function to accept a more specific event type and simplified the onChangeRaw prop by directly passing the handler. This change enhances code clarity and maintains consistency in event handling across the DatePicker examples.
Updated various TypeScript type definitions across multiple example files to use `Array<{}>` syntax for better clarity and uniformity. This change enhances code readability and maintains consistency in how date-related types are defined throughout the documentation examples.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6040 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 30 30
Lines 3496 3496
Branches 1470 1490 +20
=======================================
Hits 3458 3458
Misses 37 37
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I enhanced the readability of the doc-sites examples by removing the redundant code.
Changes
Contribution checklist