-
Notifications
You must be signed in to change notification settings - Fork 9
Create new data loader page #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly what we are looking for out of these changes. Good work. Some small change requests but generally looking good
versioned_docs/version-4.6/developers/applications/data-loader.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-4.6/developers/applications/data-loader.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-4.6/reference/applications/data-loader.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost!
just addressing build issues and not addressing any feedback. trying to not step on your toes Nenne. :) I'm trying a new script to be able to preview a pr build locally. |
edf7053
to
48919df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't follow the steps but it looks good reading through. Looking good @nenharper 👍
This is introducing a number of unrelated changes now. Lets revert that and just have this PR be content related. Thank you! |
edbcc02
to
84b7385
Compare
yep. sorry @nenharper for messing with your pr. I'm pulling out the unrelated changes I added while the build was broken. unwinding the changes required a force push so you might need to delete your local branch and do a fresh pull and check out. real sorry for messing with your workflow. :-/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I think this is good to go as soon as the new changes are copied to docs/
and 4.5
This PR makes the data loader page more narrative and adds a corresponding reference page for dataloader