Skip to content

Conversation

nenharper
Copy link
Contributor

This PR makes the data loader page more narrative and adds a corresponding reference page for dataloader

Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what we are looking for out of these changes. Good work. Some small change requests but generally looking good

@kriszyp kriszyp requested a review from heskew September 18, 2025 13:00
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost!

@heskew
Copy link
Contributor

heskew commented Sep 29, 2025

just addressing build issues and not addressing any feedback. trying to not step on your toes Nenne. :) I'm trying a new script to be able to preview a pr build locally.

@heskew heskew force-pushed the nenne/data-loader-page branch 3 times, most recently from edf7053 to 48919df Compare September 29, 2025 23:05
Copy link
Contributor

@heskew heskew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't follow the steps but it looks good reading through. Looking good @nenharper 👍

@Ethan-Arrowood
Copy link
Contributor

This is introducing a number of unrelated changes now. Lets revert that and just have this PR be content related. Thank you!

@heskew heskew force-pushed the nenne/data-loader-page branch from edbcc02 to 84b7385 Compare September 30, 2025 17:01
@heskew
Copy link
Contributor

heskew commented Sep 30, 2025

yep. sorry @nenharper for messing with your pr. I'm pulling out the unrelated changes I added while the build was broken.

unwinding the changes required a force push so you might need to delete your local branch and do a fresh pull and check out. real sorry for messing with your workflow. :-/

Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I think this is good to go as soon as the new changes are copied to docs/ and 4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants