Skip to content

Conversation

nenharper
Copy link
Contributor

This PR makes the fastify page more narrative and adds a reference for it

Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could've consulted the outline before you spent time rewriting this section. We are moving away from recommending fastfy routes and rather want users to be implementing custom resources instead (which has only been briefly mentioned previously). I think we need to discuss as a team if it makes sense to even have this part of the guide still in play. I agree some reference for it will always be necessary, but it could be potentially omitted from this guide.


<!-- ## clustering -->

## fastifyRoutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely want to keep this part as we'll still support fastify through this built in and there are customers actively using it on this version too. We aren't removing fastify support yet; just don't want to promote its use anymore

Copy link
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is only for changing 4.5 and 4.6 docs, but not touching current/4.7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants