fix: Return a basic auth client if we flag for basic auth

https://harperdb.atlassian.net/browse/STUDIO-647

Author: dawsontoth

src/integrations/api/instance/auth/useInstanceLoginMutation.ts

@@ -44,17 +44,19 @@ export async function onInstanceLoginSubmit({
 	}
 
 	try {
+		const auth = {
+			username,
+			password,
+		};
 		const user = await getInstanceUserInfo({
 			instanceClient,
-			auth: {
-				username,
-				password,
-			},
+			auth,
 		});
-		authStore.flagForBasicAuth(entityId, { username, password });
+		authStore.flagForBasicAuth(entityId, auth);
 		return {
 			message,
 			user,
+			instanceClient: getInstanceClient({ id: entityId }),
 		};
 	} catch (err) {
 		if (isLocalStudio) {
@@ -74,7 +76,7 @@ export async function onInstanceLoginSubmit({
 	return {
 		message,
 		user,
-		instanceClient,
+		instanceClient: fabricInstanceClient,
 	};
 }
 

src/integrations/api/instance/auth/useInstanceResetPasswordMutation.ts

@@ -40,7 +40,7 @@ async function onInstanceResetPassword({
 		if (loginResponse.instanceClient) {
 			instanceClient = loginResponse.instanceClient;
 		}
-		// then we can either alter...
+		// if the usernames match, we need to alter the user...
 		if (desiredUsername === defaultClusterUsername) {
 			await onAlterUser({
 				username: desiredUsername,