Restore compatibility with haxe prior to 4.1 #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e2f6072 broke compatibility with haxe versions prior to 4.1, as the
forloops used in themakeMapfunction rely on thekeysarray to supportArrayKeyValueIterator, a feature introduced in haxe 4.1.hscript documentation does not specify any requirement regarding a minimum haxe version. I know haxe 4.0.X is quite old, but some projects still rely on it.
As such, I restored the "old code" prior to the breaking commit, while integrating it within the
makeMapfunction, in between#if (haxe >= 4.1)guards. With this fix, hscript does compile with haxe 4.02 and 4.0.3 (not tested with other versions).