feat: reducing required swift version #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduces swift required to build this package to Swift 5.6 - reduces macOS support back to allow/support Catalina (10.15) - adds explicit iOS and watchOS support
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 4 4
Lines 1631 1631
=======================================
Hits 1600 1600
Misses 31 31 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a dead-simple linear bucket histogram I'm using in an existing app, and I'd very much like to replace it with this HdrHistogram implementation - but I still need to back-support to Catalina for that app. I checked this package locally, and lowering the versions doesn't impact anything currently - but I realize there's more development that you have in mind here. So... I'm opening this PR to downgrade the required versions of Swift, and related OS pieces, for your consideration.
Description
How Has This Been Tested?
swift build&&swift testMinimal checklist:
DocCcode-level documentation for any public interfaces exported by the package