Skip to content

Body text height scoping issue? #166

@EHackettTriCore

Description

@EHackettTriCore

Issue:
Helix UI for search the X icon was floating a little low in some views and not others. I tracked it down and it looks like the demos below in the table are aligned properly but not when it's a standalone search.

screen shot 2018-03-23 at 1 30 14 pm
screen shot 2018-03-23 at 1 30 17 pm

I tracked it down to a line-height issue. The searches with Kitten are inheriting line-height from the table I believe so they look correct.

I believe the issue stems from the line-height: 1.5rem; assigned to the body. It might be worth removing that line and scoping other line-heights? Or scoping the line-height on the hx-search component.

https://github.com/rackerlabs/helix-ui/blob/f37a9e6b772586ca562ec25abda3b0c61fe566be/src/helix-ui/styles/base/typography.less#L11

Noticed this while working on CTUI.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions