Skip to content

Conversation

@shaleen76
Copy link
Contributor

@shaleen76 shaleen76 commented Oct 14, 2018

Unit test framework along with code coverage report generator using Istanbul tool.

JIRA: SURF-1440

LGTM's

  • Dev LGTM
  • Zoom LGTM

@shaleen76 shaleen76 self-assigned this Oct 14, 2018
@shaleen76 shaleen76 requested review from CITguy and catsiller October 14, 2018 06:32
@HelixUI
Copy link
Contributor

HelixUI commented Oct 14, 2018

Deploy preview for helix-ui ready!

Built with commit bcf6ac9

https://deploy-preview-355--helix-ui.netlify.com

@100stacks 100stacks self-requested a review October 15, 2018 16:39
Copy link
Contributor

@CITguy CITguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

.gitignore Outdated
_config.private.js

# Removing Coverage Reports folder created.
coverage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add .nyc_output/ to list of ignored files

Copy link

@catsiller catsiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zoom lgtm

@CITguy CITguy merged commit 08f91d5 into master Oct 15, 2018
@CITguy CITguy deleted the unit-testing-coverage-report branch October 15, 2018 19:02
@100stacks 100stacks removed their request for review October 18, 2018 20:16
@100stacks 100stacks added this to the v0.15.0 milestone Oct 18, 2018
@CITguy CITguy removed this from the v0.15.0 milestone Oct 25, 2018
@CITguy CITguy modified the milestone: v0.15.0-rc.0 Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants