Better Attr Parsing #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major performance improvment plus support for boolean attr and quotes.
Collaborator
tests for hyphens and colons
Collaborator
|
Hello @HenrikJoreteg and @frontmesh we have three people who think this change would be great, and it fixes multiple issues. We've added tests and they pass. Could we get a review & merge, please? Thanks! |
Owner
kranges
commented
Aug 20, 2019
Collaborator
Author
kranges
left a comment
kranges
left a comment
There was a problem hiding this comment.
Hoping to come back to the regex and clean it up eventually but it is officially running on production.
This was referenced Aug 20, 2019
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boasting a major performance gain this PR also allows opposite quotes inside of attributes ("'something'" or '"something"') and Boolean attributes.
This is a more thorough solution to the problems presented in #13 and #19.