Skip to content

Conversation

@gquemener
Copy link
Contributor Author

If you'd have some time to review it @Herzult, that'd be great, please :)

Some tools like composer write human-related non-error messages to
stderr, thus it's not safe to rely on stderr to decide if the command
failed.

More info:
  - composer/composer#3795 (comment)
  - composer/composer#1905 (comment)
  - composer/composer#3715 (comment)
@Herzult
Copy link
Owner

Herzult commented Mar 17, 2015

You are right, exit code is more appropriate to determine wether a command was successful or not, thanks ! :)

Herzult added a commit that referenced this pull request Mar 17, 2015
Rely on last command exit status to raise error
@Herzult Herzult merged commit d569d15 into Herzult:master Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants