Skip to content

Api1600 extended support #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2020
Merged

Api1600 extended support #38

merged 3 commits into from
May 6, 2020

Conversation

@AsisBagga
Copy link
Contributor

@AsisBagga AsisBagga commented May 6, 2020 •
edited
Loading

Description

Added extended Support to Server Hardware, Server Hardware Type. Logical Interconnects, Logical Interconnects Group, Interconnects, and Interconnects types.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass for Python 2.7+ & 3.4+($ tox).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
    • New endpoints supported are updated in the endpoints-support.md file.
  • Changes are documented in the CHANGELOG.

soodpr
soodpr approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@soodpr soodpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sijeesh
sijeesh approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@sijeesh sijeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AsisBagga AsisBagga merged commit e8cf8cc into master May 6, 2020
@chebroluharika chebroluharika deleted the API1600_Extended_Support branch July 17, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sijeesh sijeesh sijeesh approved these changes

@soodpr soodpr soodpr approved these changes

@madhav-bharadwaj madhav-bharadwaj Awaiting requested review from madhav-bharadwaj

+1 more reviewer

@VenkateshRavula VenkateshRavula VenkateshRavula approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AsisBagga @sijeesh @soodpr @VenkateshRavula