feat: switch to using the builder pattern for improved type safety #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah merge conflicts |
CardboardTurkey
force-pushed
the
feat/builder
branch
from
1440391 to
12d3525
Compare
Signed-off-by: Kiran Ostrolenk <kiran@ostrolenk.co.uk>
See [markdownlint] for more info. [markdownlint]: https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md Signed-off-by: Kiran Ostrolenk <kiran@ostrolenk.co.uk>
Signed-off-by: Kiran Ostrolenk <kiran@ostrolenk.co.uk>
Configuring the parsing of patterns is now managed using the builder pattern. Signed-off-by: Kiran Ostrolenk <kiran@ostrolenk.co.uk>
CardboardTurkey
force-pushed
the
feat/builder
branch
from
12d3525 to
5062289
Compare
|
I moved some of the tests from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: add test for known bug in comparison
Signed-off-by: Kiran Ostrolenk kiran@ostrolenk.co.uk
docs(README): fix markdown issues
See markdownlint for more info.
Signed-off-by: Kiran Ostrolenk kiran@ostrolenk.co.uk
chore: cargo fmt
Signed-off-by: Kiran Ostrolenk kiran@ostrolenk.co.uk
feat: switch to using the builder pattern for improved type safety
Configuring the parsing of patterns is now managed using the builder
pattern.
Signed-off-by: Kiran Ostrolenk kiran@ostrolenk.co.uk
Closes #19