-
-
Notifications
You must be signed in to change notification settings - Fork 71
feat: scope detection to all packages #1410
Conversation
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Since this doesn't change any behaviour, let's merge this and I'll build on it in a new review to check cask changes. |
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine! Need to revert/fix if it ends up trying to install casks in third party tap CI.
|
Looks like this causes https://github.com/Homebrew/homebrew-core/actions/runs/13920934639/job/38953815106#step:4:29 |
|
Getting similar errors on my third-party tap... https://github.com/gromgit/homebrew-dev/actions/runs/13919301458/job/38948756101?pr=27#step:7:19 |
@SMillerDev can you do this manually given #1440 please? |
Rework of #1006 now that there is more linux support for casks.