Optimize endpoint blacklist #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @MickaelBergem,
as I was reading through the code, I realized that checking for blacklisted endpoint could be tedious as the list grows.
I tested it
the result was obvious, the more endpoint you add, the longer it takes:
with the code from this PR, the result is better even for a short list:
With this PR, you pay the
re.compiileprize once at the init ofHowFastFlaskMiddleware- I don't know if it is worth it.