Fix request consumption in server.js #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously stream errors during `req` consumption would lead to a hanged connection and resource/memory leak. This also removes redundant double-promise from receiveBody. PR-URL: #174
lundibundi
force-pushed
the
fix-req-consume
branch
from
9570b80 to
62e5a4e
Compare
RobinzCalvin
pushed a commit
to RobinzCalvin/NodejsStarter
that referenced
this pull request
Dec 6, 2022
Previously stream errors during `req` consumption would lead to a hanged connection and resource/memory leak. This also removes redundant double-promise from receiveBody. PR-URL: HowProgrammingWorks/NodejsStarterKit#174
0xmautone
added a commit
to 0xmautone/node-web3-boilerplate
that referenced
this pull request
Oct 28, 2024
Previously stream errors during `req` consumption would lead to a hanged connection and resource/memory leak. This also removes redundant double-promise from receiveBody. PR-URL: HowProgrammingWorks/NodejsStarterKit#174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously stream errors during
reqconsumption would lead to a hangedconnection and resource/memory leak.
This also removes redundant double-promise from receiveBody.