Skip to content

Commit 44a4630

Browse files
author
Huelse
committed
Modify: improve the illustrate and delete useless code.
1 parent 0803a18 commit 44a4630

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

README.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,18 +30,21 @@ This is a python binding for the Microsoft SEAL library.
3030

3131
# Get the repo or download from the releases
3232
git clone https://github.com/Huelse/SEAL-Python.git
33-
git submodule init
33+
cd SEAL-Python
34+
git submodule init && git submodule update
35+
# Get the newest SEAL and pybind11
36+
git submodule update --remote
3437

3538
# Build the SEAL lib
3639
cd ./SEAL
3740
cmake -S . -B build -DSEAL_USE_MSGSL=OFF -DSEAL_USE_ZLIB=OFF -DSEAL_USE_ZSTD=OFF
3841
cmake --build build
3942
cd ..
4043

41-
# Run the setup.py
44+
# Run the setup.py
4245
python3 setup.py build_ext -i
4346
```
44-
47+
4548
* #### Windows
4649

4750
Visual Studio 2019 or newer is required. And use the **x64 Native Tools Command Prompt for Visual Studio 2019** command prompt to configure and build the Microsoft SEAL library. It's usually can be found in your Start Menu.
@@ -50,14 +53,14 @@ This is a python binding for the Microsoft SEAL library.
5053
# Same as above
5154

5255
# Build the SEAL lib
53-
cmake -S . -B build -G "Visual Studio 16 2019" -A x64 -DSEAL_USE_MSGSL=OFF -DSEAL_USE_ZLIB=OFF -DSEAL_USE_ZSTD=OFF
56+
cmake -S . -B build -G Ninja -DSEAL_USE_MSGSL=OFF -DSEAL_USE_ZLIB=OFF -DSEAL_USE_ZSTD=OFF
5457
cmake --build build --config Release
5558

5659
# Run the setup.py
5760
python setup.py build_ext -i
5861
```
5962

60-
Microsoft official video [SEAL in windows](https://www.microsoft.com/en-us/research/video/installing-microsoft-seal-on-windows/).
63+
Microsoft SEAL official [illustrate](https://github.com/microsoft/SEAL#building-microsoft-seal-manually).
6164

6265

6366

setup.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
extra_objects[0] = './SEAL/build/lib/Release/seal-3.6.lib'
2121

2222
if not os.path.exists(extra_objects[0]):
23-
print('Can not find the seal lib')
24-
print('Compile the seal lib first or check the path')
23+
print('Can not find the seal lib,')
24+
print('Compile the seal lib first or check the path.')
2525
exit(1)
2626

2727
ext_modules = [
@@ -43,8 +43,5 @@
4343
description='Python wrapper for the Microsoft SEAL',
4444
url='https://github.com/Huelse/SEAL-Python',
4545
license='MIT',
46-
setup_requires=[
47-
'numpy'
48-
],
4946
ext_modules=ext_modules,
5047
)

0 commit comments

Comments
 (0)