plan: post-Tier-1B follow-ups (PR-E1 + PR-E2)#16
Merged
Conversation
…-E2 plan Catches from PR-D1, PR-D2, PR-D3 reviews that were intentionally deferred until Tier 1B landed are gathered into one document to prevent them from getting lost across review threads. PR-E1 (small, 1-day): risk_score [0,1] re-normalisation, VALID_HTTP_CALL_MATCHES rename, two inline comments, two doc fixes. PR-E2 (refactor): consolidate the second three-strategy ladder in graph_enrich.py:720-724 onto the canonical resolver. Refs: - PR-D1 #12 obs 2 (strategy-ladder duplicate) - PR-D2 #13 post-D3 follow-ups (anchor-fills-from-builtin doc, channel field) - PR-D3 #15 obs 1-3, 5 (risk-score contract, VALID_HTTP_CALL_MATCHES rename, two reader comments)
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A single plan document collecting every non-blocking observation from the PR-D1, PR-D2, and PR-D3 reviews that was intentionally deferred until Tier 1B landed. Without this, those catches risk getting lost across review threads.
Why now
Tier 1B is merged (PR-D3 → master at
c600bf2). Before moving to Tier 2, these are the small contract/naming/doc fixes that the review threads agreed to address "after PR-D3". Collecting them in one place lets them ship as one or two small PRs instead of being rediscovered later.What's in the plan
risk_scorecontract change[0,1]→[0,6+]— re-normaliseVALID_HTTP_CALL_MATCHES→VALID_CALL_MATCHESpass6_match_edges_match_call_edgeanchor-fills-from-builtin behaviourchanneltoOutgoingCallDeclsketchgraph_enrich.py:720-724Recommended split
The plan covers both. Implementation guidance + DoD per PR are inline.
Tests
No code changes here — plan-only. Tier 1B test baseline (260 passed, 4 skipped) is preserved.
Files
plans/PLAN-POST-TIER1B-FOLLOWUPS.md— newOnce approved + merged, I'll draft the Cursor task prompts for PR-E1 (and PR-E2 separately when that one's ready). The plan also notes that item 6 should land before the Tier-1B cleanup PR moves the proposal file — or we just edit it in its new home. Either is fine.