This repository was archived by the owner on Apr 18, 2024. It is now read-only.
fix: LSDV-4673: Fix drawing with Rect3Point tool in relative coords #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
+ Coverage 65.79% 66.10% +0.30%
==========================================
Files 436 436
Lines 27316 27360 +44
Branches 7253 7265 +12
==========================================
+ Hits 17973 18086 +113
+ Misses 8027 7970 -57
+ Partials 1316 1304 -12
☔ View full report in Codecov by Sentry. |
src/mixins/DrawingTool.js
Outdated
Comment on lines
502
to
503
| const maxStageWidth = isFF(FF_DEV_3793) ? 100 : self.obj.stageWidth; | ||
| const maxStageHeight = isFF(FF_DEV_3793) ? 100 : self.obj.stageHeight; |
Contributor
There was a problem hiding this comment.
can you put the 100 in a variable and a comment to help explain why 100
Contributor
There was a problem hiding this comment.
I think that 100 is used in src/regions/RectRegion.js aswell - would it make sense to define it as a constant value so we can reuse it where needed - would help the code be more readable
Contributor
Author
There was a problem hiding this comment.
@yyassi-heartex That's a great Idea. I hope I placed this constants in the right place.
# Conflicts: # tests/functional/package.json # tests/functional/yarn.lock
yyassi-heartex
approved these changes
Jun 7, 2023
bmartel
approved these changes
Jun 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
Rect3Pointdrawing tool does not work in relative coordinates mode.ff_front_dev_2132_rotating_bounding_box- to enableRect3Pointtool for<Rectangle/>control tagfflag_fix_front_dev_3793_relative_coords_short- to enable relative coordinates mode for<ImageView/>object tag.There are also some problems with
Rect3Pointitself. Some edge cases can provide unexpectedNaNvalues.What does this fix?
This PR allows
Rect3Pointto work in relative coordinates and fix the mathematics of drawing.What libraries were added/updated?
@heartexlabs/ls-testDoes this change affect performance?
Nope
Does this change affect security?
Nope
What alternative approaches were there?
N/A
What feature flags were used to cover this change?
fflag_fix_front_lsdv_4673_rect3point_relative_310523_shortand related:
ff_front_dev_2132_rotating_bounding_boxfflag_fix_front_dev_3793_relative_coords_shortDoes this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Rect3Point