This repository was archived by the owner on Apr 18, 2024. It is now read-only.
chore: LEAP-221: Remove Taxonomy flags #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First try, not fully working. Now `<Choice selected="true">` will work inside Taxonomy as well.
- fix example for classifications - fix typo in FF link - add list of all Taxonomy and Choices related FFs
Not the best way to do it anyway
Children should be init before other processes like setDefaultValues()
This case can happen during store init in Label Stream, task will be loaded later.
hlomzik
changed the title
bmartel
approved these changes
Oct 26, 2023
Gondragos
reviewed
Oct 26, 2023
| simpleData | ||
| } from 'data/control_tags/choice'; | ||
| import { FF_DEV_2007 } from '@heartexlabs/ls-test/feature-flags'; | ||
| } from '../../data/control_tags/choice'; |
Contributor
There was a problem hiding this comment.
Is it an accountable change? I mean the change in from <path> part.
Collaborator
Author
There was a problem hiding this comment.
I think it's a bit early to introduce aliases without proper transition. Something was complaining about the path, like TS or something. And they won't work in monorepo right now.
Gondragos
approved these changes
Oct 26, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
* fix: LSDV-1476: Fix selected=true for Taxonomy First try, not fully working. Now `<Choice selected="true">` will work inside Taxonomy as well. * Fix example; typo in FFs; list of taxonomy FFs - fix example for classifications - fix typo in FF link - add list of all Taxonomy and Choices related FFs * Add test for preselected Taxonomy; with 3617 FF off * fix work with shared store (FF_DEV_3617) * Add tests for static/dynamic + on/off cases * Linting + remove unused alert * Remove FF_DEV_2007 flag * Remove FF_DEV_2007_DEV_2008 FF * Actually use ffState in test * Remove FF_DEV_2100_A * Remove FF_DEV_2244 * Linting from prev commits * Add missing required flags * Fix TS recognition of cypress globals * Remove unused FF groupping Not the best way to do it anyway * It does work with FF_DEV_3617 after the fix! * Add comment about fixed updateValue() * Update ls-frontend-test to have hasNoSelected() * Fix tests * Add FF to fix init order Children should be init before other processes like setDefaultValues() * Make it safe to `updateValue()` without task This case can happen during store init in Label Stream, task will be loaded later. * Update ls-frontend-test * Remove flags from tests * Small fixes for test data * Connect updated test helpers * Get rid of unused FF list * Update ls-frontend-test --------- Co-authored-by: hlomzik <hlomzik@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 4 old feature flags for Taxonomy and Choices tags:
ff_dev_2007_rework_choices_280322_shortff_dev_2007_dev_2008_dynamic_tag_children_250322_shortff_dev_2100_preselected_choices_250422_shortff_front_dev_2244_nested_choices_des_107_160522_shortAll tests, docs and code are cleaned up, all changes made as if
isFF()for this flags was always true.PR fulfills these requirements
Describe the reason for change
Flags should live a short amount of time giving us a failsafe if new feature or fix went wrong. They should be removed when it's settled, checked and enabled for any env.
And those flags are really old.
Does this change affect performance?
Flags are already there and enabled for ages, so all performance effects are already there.
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
Taxonomy, Dynamic Children