Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

Conversation

@Travis1282
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

Scroll was not working in the preview window

What does this fix?

This takes main content window outside of document to calculate scroll box

What is the new behavior?

It scrolls in the preview window

What is the current behavior?

it does not scroll

What libraries were added/updated?

none

Does this change affect performance?

no

Does this change affect security?

no

What alternative approaches were there?

n/a

What feature flags were used to cover this change?

none

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

paragraph scroll preview window

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (511a0e8) 67.04% compared to head (8380c5f) 66.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   67.04%   66.97%   -0.08%     
==========================================
  Files         437      437              
  Lines       27109    27111       +2     
  Branches     7184     7187       +3     
==========================================
- Hits        18175    18157      -18     
- Misses       7707     7722      +15     
- Partials     1227     1232       +5     
Impacted Files Coverage Δ
src/tags/object/Paragraphs/HtxParagraphs.js 75.00% <0.00%> (-0.68%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Travis1282
Copy link
Contributor Author

Travis1282 commented Jul 11, 2023

/git merge master

Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-lsdv-5335/scrollable-preview (fe45a6b)

Workflow run

@Travis1282 Travis1282 enabled auto-merge (squash) July 14, 2023 14:58
@Travis1282 Travis1282 merged commit ccf87de into master Jul 14, 2023
@Travis1282 Travis1282 deleted the fb-lsdv-5335/scrollable-preview branch July 14, 2023 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants