Create short URL API #7 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new API endpoint for creating shortened URLs and refactors the Appwrite client initialization in the redirect endpoint for improved code reuse.
- Added api/create.js for handling URL shortening with document creation in the Appwrite database.
- Moved client and database initialization in api/redirect.js to the top of the file to eliminate redundancy.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| api/redirect.js | Refactored to initialize the Appwrite client and database at the top. |
| api/create.js | Added a new endpoint to create a short URL, with creation logic in the Appwrite database. |
|
|
||
| console.log("Create URL: ", shortCode, "\n", "Long URL: ", longURL); | ||
|
|
||
| if (!shortCode && !longURL) { |
There was a problem hiding this comment.
The condition uses '&&' instead of '||'. This may allow one of the required parameters to be missing. Update the condition to 'if (!shortCode || !longURL)' to ensure both parameters are provided.
Suggested change
| if (!shortCode && !longURL) { | |
| if (!shortCode || !longURL) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality for creating and redirecting shortened URLs using the Appwrite backend. It also refactors the
api/redirect.jsfile to improve code reuse by initializing the Appwrite client at the top of the file instead of within the handler function.New Feature: URL Shortening
api/create.jsto handle the creation of shortened URLs. This endpoint initializes the Appwrite client, creates a document in the database with the providedshortCodeandlongURL, and returns the shortened URL upon success.Code Refactoring: Appwrite Client Initialization
api/redirect.jsto the top of the file, outside the handler function, to improve code reuse and reduce redundancy. [1] [2]