comments updated & code logic improvised

HypertextAssassin0273 · HypertextAssassin0273 · commit f72ee09291f1 · 2025-01-10T01:56:31.000+05:00
ThreadPoolExecutor is replaced with ProcessPoolExecutor to increase execution speed
diff --git a/c4_troubleshooting_debugging_techniques/m2_slowness/src/retrieve_images_online.py b/c4_troubleshooting_debugging_techniques/m2_slowness/src/retrieve_images_online.py
@@ -51,3 +51,7 @@ def main():
 
 if __name__ == "__main__":
     main()
+
+
+# NOTE: The ACCESS_KEY is a placeholder for the actual access key that you need to obtain from Unsplash.
+# SIDE-NOTE: we can improve the script by adding concurrency to download multiple images simultaneously.
diff --git a/c4_troubleshooting_debugging_techniques/m2_slowness/src/thumbnail_generator.py b/c4_troubleshooting_debugging_techniques/m2_slowness/src/thumbnail_generator.py
@@ -49,7 +49,7 @@ def main():
 
     os.makedirs('thumbnails', exist_ok=True) # create the thumbnail directory
 
-    executor = futures.ThreadPoolExecutor()
+    executor = futures.ProcessPoolExecutor() # alternate: ThreadPoolExecutor()
     for root, _, files in os.walk('images'):
         for basename in progress_bar(files):
             if basename.endswith('.jpg'):
@@ -64,3 +64,7 @@ def main():
 
 if __name__ == "__main__":
     sys.exit(main())
+
+
+# NOTE: here ProcessPoolExecutor() performs better than ThreadPoolExecutor() because of the GIL in Python.
+# SIDE-NOTE: GIL might become optional in upcoming Python version (3.13).
