Add auth check and fix the OptOutServiceVerticle tests #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyi-gao-ttd
changed the title
sunnywu
reviewed
Jan 10, 2023
| @Test | ||
| public void replicate_expect200(TestContext context) { | ||
| verifyStatus(context, replicateQuery(234), 200); | ||
| verifyStatus(context, replicateQuery(234), 200, "Bearer test-optout-operator-key"); |
Contributor
There was a problem hiding this comment.
very nitpick: can just make com.uid2.optout.vertx.TestOperatorKeyProvider#TEST_OPTOUT_KEY public can get the name directly instead of hardcoding it again to be inconsistent. Can probably say the same about com.uid2.optout.vertx.OptOutServiceVerticleTest#internalTestKey definition
Contributor
Author
There was a problem hiding this comment.
Thanks, I think this make sense, I've upated the tests
ghost
reviewed
Jan 12, 2023
src/test/java/com/uid2/optout/vertx/TestOperatorKeyProvider.java
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jan 12, 2023
src/test/java/com/uid2/optout/vertx/TestOperatorKeyProvider.java
Outdated
Show resolved
Hide resolved
ghost
reviewed
Jan 12, 2023
src/test/java/com/uid2/optout/vertx/OptOutServiceVerticleTest.java
Outdated
Show resolved
Hide resolved
ghost
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: