Skip to content

feat: add constitutive properties to show entities operation #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2025
Merged

feat: add constitutive properties to show entities operation #116

merged 2 commits into from
Oct 10, 2025

Conversation

@AlessandroPomponio
Copy link
Member

@AlessandroPomponio AlessandroPomponio commented Oct 9, 2025 •
edited
Loading

Context

Resolves #114

Changes

ado show entities operation randomwalk-1.0.2.dev39+7f0c421.dirty-43dfdf

Before

               result_index                                                                              identifier peptide_mineralization-adsorption_timeseries peptide_mineralization-adsorption_plateau_value  valid
request_index                                                                                                                                                                                                          
0                         0  peptide_identifier.test_peptide-peptide_concentration.0.1-lanthanide_concentration.0.1                        adsorption_timeseries                        adsorption_plateau_value   True
1                         0  peptide_identifier.test_peptide-peptide_concentration.0.1-lanthanide_concentration.0.4                        adsorption_timeseries                        adsorption_plateau_value   True
2                         0  peptide_identifier.test_peptide-peptide_concentration.0.1-lanthanide_concentration.0.6                        adsorption_timeseries                        adsorption_plateau_value   True
3                         0  peptide_identifier.test_peptide-peptide_concentration.0.1-lanthanide_concentration.0.8                        adsorption_timeseries                        adsorption_plateau_value   True
4                         0  peptide_identifier.test_peptide-peptide_concentration.0.4-lanthanide_concentration.0.1                        adsorption_timeseries                        adsorption_plateau_value   True
5                         0  peptide_identifier.test_peptide-peptide_concentration.0.4-lanthanide_concentration.0.4                        adsorption_timeseries                        adsorption_plateau_value   True
6                         0  peptide_identifier.test_peptide-peptide_concentration.0.4-lanthanide_concentration.0.6                        adsorption_timeseries                        adsorption_plateau_value   True
7                         0  peptide_identifier.test_peptide-peptide_concentration.0.4-lanthanide_concentration.0.8                        adsorption_timeseries                        adsorption_plateau_value   True
8                         0  peptide_identifier.test_peptide-peptide_concentration.0.6-lanthanide_concentration.0.1                        adsorption_timeseries                        adsorption_plateau_value   True
9                         0  peptide_identifier.test_peptide-peptide_concentration.0.6-lanthanide_concentration.0.4                        adsorption_timeseries                        adsorption_plateau_value   True

After

               result_index                                                                              identifier                     generatorid  lanthanide_concentration  peptide_concentration peptide_identifier peptide_mineralization-adsorption_timeseries peptide_mineralization-adsorption_plateau_value  valid
request_index                                                                                                                                                                                                                                        
0                         0  peptide_identifier.test_peptide-peptide_concentration.0.1-lanthanide_concentration.0.1  explicit_grid_sample_generator                       0.1                    0.1       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True
1                         0  peptide_identifier.test_peptide-peptide_concentration.0.1-lanthanide_concentration.0.4  explicit_grid_sample_generator                       0.4                    0.1       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True
2                         0  peptide_identifier.test_peptide-peptide_concentration.0.1-lanthanide_concentration.0.6  explicit_grid_sample_generator                       0.6                    0.1       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True
3                         0  peptide_identifier.test_peptide-peptide_concentration.0.1-lanthanide_concentration.0.8  explicit_grid_sample_generator                       0.8                    0.1       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True
4                         0  peptide_identifier.test_peptide-peptide_concentration.0.4-lanthanide_concentration.0.1  explicit_grid_sample_generator                       0.1                    0.4       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True
5                         0  peptide_identifier.test_peptide-peptide_concentration.0.4-lanthanide_concentration.0.4  explicit_grid_sample_generator                       0.4                    0.4       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True
6                         0  peptide_identifier.test_peptide-peptide_concentration.0.4-lanthanide_concentration.0.6  explicit_grid_sample_generator                       0.6                    0.4       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True
7                         0  peptide_identifier.test_peptide-peptide_concentration.0.4-lanthanide_concentration.0.8  explicit_grid_sample_generator                       0.8                    0.4       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True
8                         0  peptide_identifier.test_peptide-peptide_concentration.0.6-lanthanide_concentration.0.1  explicit_grid_sample_generator                       0.1                    0.6       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True
9                         0  peptide_identifier.test_peptide-peptide_concentration.0.6-lanthanide_concentration.0.4  explicit_grid_sample_generator                       0.4                    0.6       test_peptide                        adsorption_timeseries                        adsorption_plateau_value   True

@AlessandroPomponio
Copy link
Member Author

AlessandroPomponio commented Oct 9, 2025

@michael-johnston should we also drop generatorid?

@DRL-NextGen
Copy link
Member

DRL-NextGen commented Oct 9, 2025 •
edited
Loading

Checks Summary

Last run: 2025-10-10T08:19:26.582Z

Code Risk Analyzer vulnerability scan found 2 vulnerabilities:

Severity Identifier Package Details Fix
🔷Medium CVE-2025-50181 urllib3
urllib3 redirects are not disabled when retries are disabled on PoolManager instantiationGHSA-pq67-6m6q-mj2v

urllib3:2.3.0->kubernetes:34.1.0
 2.5.0
🔷Medium CVE-2025-50182 urllib3
urllib3 does not control redirects in browsers and Node.jsGHSA-48p4-8xcf-vxj5

urllib3:2.3.0->kubernetes:34.1.0
 2.5.0

@michael-johnston
Copy link
Member

michael-johnston commented Oct 9, 2025

@michael-johnston should we also drop generatorid?

It’s there for when the sampling gets more complicated

michael-johnston
michael-johnston requested changes Oct 9, 2025
View reviewed changes
Copy link
Member

@michael-johnston michael-johnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put the constitutive properties before the observed (after the id). To match show entities
Space (also seems more natural)

@AlessandroPomponio
Copy link
Member Author

AlessandroPomponio commented Oct 10, 2025

Can we put the constitutive properties before the observed (after the id). To match show entities Space (also seems more natural)

Sure: 4f572b7
I have updated the before/after as well

@michael-johnston
Copy link
Member

michael-johnston commented Oct 10, 2025

@michael-johnston should we also drop generatorid?

Lets leave it for now

@AlessandroPomponio AlessandroPomponio added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit 9ce2735 Oct 10, 2025
18 checks passed
@AlessandroPomponio AlessandroPomponio deleted the ap_114_add_constitutive_properties_to_show_entities_operation branch October 10, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-johnston michael-johnston michael-johnston approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add constitutive properties to show entities operation

4 participants

@AlessandroPomponio @DRL-NextGen @michael-johnston