-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add vector property domain #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
michael-johnston
wants to merge
39
commits into
main
Choose a base branch
from
maj_vector_property
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+207
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was getting long and complex. Create one function for each domain type that checks if another domain is a sub-domain of a domain of that type.
Since the entityspace is fixed on creation strictly it can't have an open categorical dimension. We convert it to categorical with the values passed which will always be a sub-domain of the experiments open-categorical domain.
Just decorate a python function with @custom_experiments to add it - No need for YAML - No need for ado_actuators namespace
To use new decorator
To use new decorator
…_plugins # Conflicts: # orchestrator/schema/domain.py
As it can't be serialized
also refactor code into more primitive functions
to output_property_identifiers
A domain for a property whose value is a vector.
Member
|
Checks Summary Last run: 2025-11-21T10:41:32.892Z Code Risk Analyzer vulnerability scan found 2 vulnerabilities:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A vector property domain is a domain consisting of multiple numeric elements all of with same property domain e.g. a vector could have 100 elements each of which has an integer domain with values from 0 to 100.
It provides a way to succinctly describe such a domain.